test(replay): Add Playwright tests for error-mode and error linking #7251
Conversation
Lms24
changed the title
Lms24
force-pushed
the
lms/replay-pw-errors
branch
from
3a847ab to
3a12c53
Compare
|
|
||
| expect(event0).toEqual( | ||
| getExpectedReplayEvent({ | ||
| contexts: { replay: { error_sample_rate: 1, session_sample_rate: 0 } }, |
There was a problem hiding this comment.
This also really shows a problem with how we handle this today 😅 we should address this with hooks as soon as we can, IMHO, as this is pretty confusing if you think about this 😅 (the test is good though to make clear this is expected)
There was a problem hiding this comment.
Yes, agreed. As we discussed on Monday, the test, in this case, shows how this behavior is unexpected to users. Will leave a note about this in the test file to clarify.
| replay_type: 'error', | ||
| }), | ||
| ); | ||
|
|
There was a problem hiding this comment.
Should we stop the test here, I wonder? As I guess everything below here is kind of a duplicate of the other test(s) about error --> session mode switch?
There was a problem hiding this comment.
Yup, good point. I also streamlined the session mode tests as they tested too much-duplicated stuff (classic case of copy 🍝)
size-limit report 📦
|
This PR adds four integration tests for replays where errors occur:
ref: #7044